Fix geocoder to new 3.x API #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As index.html is using the latest version of leaflet-control-geocoder and the API changed in 3.0.0 with this example: ``` Migrate from callbacks to Promise -geocoder.geocode(query, callback); +geocoder.geocode(query).then(callback); -geocoder.reverse(latlng, scale, callback); +geocoder.reverse(latlng, scale).then(callback); Migrate from callbacks to async-await -geocoder.geocode(query, callback); +const results = await geocoder.geocode(query); -geocoder.reverse(latlng, scale, callback); +const results = await geocoder.reverse(latlng, scale); ``` The usage in the map widget also needs updating to correspond.
✅ Deploy Preview for boisterous-sunburst-a5c941 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jordigh
reviewed
Jan 14, 2025
| reject(e); | ||
| } | ||
| }); | ||
| const results = await geocoder.geocode(address); |
There was a problem hiding this comment.
This looks reasonable, but it seems like the original try-catch should be kept. Why is it no longer needed?
There was a problem hiding this comment.
I dropped it because it should just bubble out now due to using await, rather than needing explicit handling to conform it to the promise. But I can reinstate it with the logging out of caution, no problem.
paulfitz
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thanks @SevereOverfl0w ! Dropping the try/catch seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As index.html is using the latest version of leaflet-control-geocoder and the API changed in 3.0.0 with this example:
The usage in the map widget also needs updating to correspond.