Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grisp_manager from tests #50

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Conversation

maehjam
Copy link
Member

@maehjam maehjam commented Nov 13, 2024

Instead of using grisp_manager we use a test server grisp_connect_test_server that forwards all websocket traffic to listening processes (that called grisp_connect_test_server:listen()). This way we can check what grisp_connect sends over the websocket and control the response it receives in the test case.

Note 1: For now I kept using ssl (that was already implemented) in the test. We can remove it for testing in a separate PR.

Note 2: I only adjusted the existing test cases. They do not cover much.

@maehjam maehjam requested a review from sylane November 13, 2024 15:54
Copy link
Contributor

@sylane sylane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on things I feel would be better, but feel free to have a talk and shot my comments down :)

test/grisp_connect_api_SUITE.erl Outdated Show resolved Hide resolved
test/grisp_connect_api_SUITE.erl Outdated Show resolved Hide resolved
test/grisp_connect_test.hrl Outdated Show resolved Hide resolved
test/grisp_connect_test.hrl Outdated Show resolved Hide resolved
test/grisp_connect_test.hrl Outdated Show resolved Hide resolved
@maehjam maehjam requested a review from sylane November 14, 2024 13:51
test/grisp_connect_api_SUITE.erl Outdated Show resolved Hide resolved
test/grisp_connect_test_async.erl Show resolved Hide resolved
@maehjam maehjam merged commit 2422470 into main Nov 18, 2024
1 check passed
@maehjam maehjam deleted the bugfix/SEA-317-cleanup-tests branch November 18, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants