Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail pane #161

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Add detail pane #161

merged 3 commits into from
Aug 9, 2024

Conversation

martinling
Copy link
Member

@martinling martinling commented Aug 6, 2024

Adds an initial implementation of the detail pane, populated with a more detailed, multi-line description of whichever item is selected in the traffic view.

Unlike the summaries in the tree view, the detail pane will display up to 1024 bytes of payload data, wrapping across lines as required, and it is possible to select and copy from the text shown.

image

This is not a complete solution for the detail pane yet, as it doesn't address viewing the data for transfers of >1024 bytes. For this we'll need a solution based on ListView that loads data on demand, as the transfer size is unbounded.

However, it gets the new pane into the UI, and addresses the immediate need for a way to access the full content of packets and transactions.

Closes #10
Closes #156

@martinling martinling marked this pull request as ready for review August 6, 2024 16:14
@mossmann mossmann requested a review from miek August 7, 2024 17:52
@martinling
Copy link
Member Author

Revised slightly to avoid using fmt_count, which adds thousand separators, for packet and transaction IDs.

I'm still using it for timestamps, because it helps separate milli/micro/nanoseconds visually, but I don't think it's helpful for IDs. Keeping those as just digits makes it easier to e.g. paste them into Wireshark's 'Go to packet' input.

@miek miek merged commit e739bdc into greatscottgadgets:main Aug 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add word wrap for longer data with optional ASCII decoding Add a detail pane to GTK frontend
2 participants