CI: Enable rust caching for Windows, if vcpkg dependencies unchanged. #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinling
force-pushed
the
rust-cache
branch
2 times, most recently
from
7637ba4 to
d9c1c4d
Compare
Otherwise, the cache will only be kept for the default toolchain.
Our non-Rust dependency versions are fixed on Windows by our choice of vcpkg commit ID, so by using this as a key to the rust-cache action, we can cache safely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had previously disabled the
rust-cacheaction, because it could cause problems on macOS builds, where the latest GTK and dependencies are installed from Homebrew and it was possible for the cached Rust crate builds to end up pointing to library install paths that were no longer valid in the latest Homebrew install.However, Windows is currently our slowest build platform, and our non-Rust dependency versions are fixed there by our choice of vcpkg commit ID, so by using this as a key to the rust-cache action, we can cache safely.
This cuts the Windows build time from 9m33s to 4m20s. Which is still the longest (Linux & macOS are around 3 mins each), but much less annoying.