Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failures in license scripts being lost #127

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

martinling
Copy link
Member

@martinling martinling commented Jul 13, 2024

Errors returned from rust_licenses.py were being ignored, because on Windows runners, commands are executed by PowerShell, and there's no equivalent of set -e there, so a multi-line run command will ignore errors as long as the last command in the sequence succeeds. This is documented here. What a footgun!

Fix this by forcing the shell to bash (thanks @miek for the tip), and then fix the underlying failure, which was that I hadn't added BSD-2-Clause to the list of accepted licenses when adding the git-version crate in #125. Also add COPYING to the list of filenames to check for a license in the crate source, which is also needed to accept this crate.

We're about to remove the git-version dependency in #126 anyway, but these changes are valid regardless.

@martinling martinling changed the title Fix failures in license scripts being lost due to redirection Fix failures in license scripts being lost Jul 13, 2024
@martinling martinling marked this pull request as ready for review July 13, 2024 15:45
@martinling martinling merged commit 1c4d9c2 into greatscottgadgets:main Jul 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant