Fix failures in license scripts being lost #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors returned from
rust_licenses.py
were being ignored, because on Windows runners, commands are executed by PowerShell, and there's no equivalent ofset -e
there, so a multi-linerun
command will ignore errors as long as the last command in the sequence succeeds. This is documented here. What a footgun!Fix this by forcing the shell to
bash
(thanks @miek for the tip), and then fix the underlying failure, which was that I hadn't addedBSD-2-Clause
to the list of accepted licenses when adding thegit-version
crate in #125. Also addCOPYING
to the list of filenames to check for a license in the crate source, which is also needed to accept this crate.We're about to remove the
git-version
dependency in #126 anyway, but these changes are valid regardless.