Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Windows installer using cargo-wix #112

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

martinling
Copy link
Member

@martinling martinling commented Jul 3, 2024

Builds a Windows MSI installer using cargo-wix, that installs the Packetry application along with all the DLL files required for GTK4 and its dependencies.

@martinling martinling force-pushed the windows-installer branch 8 times, most recently from 0e738d8 to f2839aa Compare July 3, 2024 16:03
@martinling martinling marked this pull request as ready for review July 3, 2024 16:27
@martinling
Copy link
Member Author

martinling commented Jul 3, 2024

There's a few things this doesn't do yet, which we might want it to:

  • Sign the installer so that it runs without warnings.
  • Add the application to the Start menu and/or desktop.
  • Associate an icon with the application (see also Proposal for app icon #95).
  • Associate .pcap files with the application.
  • Display the license during installation.
  • Install a copy of the license with the application.

It works though, and could be merged as-is and improved later.

@martinling martinling marked this pull request as draft July 6, 2024 02:46
@martinling martinling force-pushed the windows-installer branch 19 times, most recently from 43467ff to d20b704 Compare July 9, 2024 18:32
@martinling martinling force-pushed the windows-installer branch 2 times, most recently from 7661d3c to 06961eb Compare July 10, 2024 01:09
@martinling martinling force-pushed the windows-installer branch 2 times, most recently from 1382218 to fa3ac9b Compare July 10, 2024 02:13
@martinling martinling marked this pull request as ready for review July 10, 2024 02:40
@martinling martinling merged commit 7c0fe3f into greatscottgadgets:main Jul 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants