Skip to content

Merge pull request #77 from martinling/more-tree-model-improvements #251

Merge pull request #77 from martinling/more-tree-model-improvements

Merge pull request #77 from martinling/more-tree-model-improvements #251

Triggered via push October 6, 2023 14:21
Status Failure
Total duration 10m 25s
Artifacts 2
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

rust.yml

on: push
Matrix: Build and test
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 25 warnings
incorrect implementation of `partial_cmp` on an `Ord` type: src/id.rs#L15
error: incorrect implementation of `partial_cmp` on an `Ord` type --> src/id.rs:15:1 | 15 | / impl<T> PartialOrd for Id<T> { 16 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> { | | ______________________________________________________________________- 17 | || self.value.partial_cmp(&other.value) 18 | || } | ||____- help: change this to: `{ Some(self.cmp(other)) }` 19 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type = note: `#[deny(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default
redundant guard: src/capture.rs#L641
error: redundant guard --> src/capture.rs:641:48 | 641 | (Some(size), Some(outcome)) if size == 0 => | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards help: try | 641 - (Some(size), Some(outcome)) if size == 0 => 641 + (Some(0), Some(outcome)) => |
redundant guard: src/capture.rs#L639
error: redundant guard --> src/capture.rs:639:39 | 639 | (Some(size), None) if size == 0 => | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards = note: `-D clippy::redundant-guards` implied by `-D warnings` help: try | 639 - (Some(size), None) if size == 0 => 639 + (Some(0), None) => |
Clippy
Clippy had exited with the 101 exit code
incorrect implementation of `partial_cmp` on an `Ord` type: src/id.rs#L15
error: incorrect implementation of `partial_cmp` on an `Ord` type --> src/id.rs:15:1 | 15 | / impl<T> PartialOrd for Id<T> { 16 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> { | | ______________________________________________________________________- 17 | || self.value.partial_cmp(&other.value) 18 | || } | ||____- help: change this to: `{ Some(self.cmp(other)) }` 19 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type = note: `#[deny(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default
redundant guard: src/capture.rs#L641
error: redundant guard --> src/capture.rs:641:48 | 641 | (Some(size), Some(outcome)) if size == 0 => | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards help: try | 641 - (Some(size), Some(outcome)) if size == 0 => 641 + (Some(0), Some(outcome)) => |
redundant guard: src/capture.rs#L639
error: redundant guard --> src/capture.rs:639:39 | 639 | (Some(size), None) if size == 0 => | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards = note: `-D clippy::redundant-guards` implied by `-D warnings` help: try | 639 - (Some(size), None) if size == 0 => 639 + (Some(0), None) => |
incorrect implementation of `partial_cmp` on an `Ord` type: src/id.rs#L15
error: incorrect implementation of `partial_cmp` on an `Ord` type --> src/id.rs:15:1 | 15 | / impl<T> PartialOrd for Id<T> { 16 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> { | | ______________________________________________________________________- 17 | || self.value.partial_cmp(&other.value) 18 | || } | ||____- help: change this to: `{ Some(self.cmp(other)) }` 19 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type = note: `#[deny(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default
redundant guard: src/capture.rs#L641
error: redundant guard --> src/capture.rs:641:48 | 641 | (Some(size), Some(outcome)) if size == 0 => | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards help: try | 641 - (Some(size), Some(outcome)) if size == 0 => 641 + (Some(0), Some(outcome)) => |
redundant guard: src/capture.rs#L639
error: redundant guard --> src/capture.rs:639:39 | 639 | (Some(size), None) if size == 0 => | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards = note: `-D clippy::redundant-guards` implied by `-D warnings` help: try | 639 - (Some(size), None) if size == 0 => 639 + (Some(0), None) => |
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (ubuntu-22.04, 1.57)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, GabrielBB/xvfb-action@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build and test (ubuntu-22.04, 1.57)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (ubuntu-22.04, 1.57)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (ubuntu-22.04, 1.57)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (ubuntu-22.04, 1.57)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (ubuntu-22.04, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, GabrielBB/xvfb-action@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build and test (ubuntu-22.04, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (ubuntu-22.04, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (ubuntu-22.04, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (ubuntu-22.04, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (macos-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, GabrielBB/xvfb-action@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build and test (macos-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (macos-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (macos-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (macos-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (macos-latest, 1.57)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, GabrielBB/xvfb-action@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build and test (macos-latest, 1.57)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (macos-latest, 1.57)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (macos-latest, 1.57)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build and test (macos-latest, 1.57)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Artifacts

Produced during runtime
Name Size
Packetry macos-latest Expired
2.13 MB
Packetry ubuntu-22.04 Expired
6.21 MB