Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to pip for dependency installation #208

Merged
merged 2 commits into from
Oct 4, 2023
Merged

switch to pip for dependency installation #208

merged 2 commits into from
Oct 4, 2023

Conversation

grvvy
Copy link
Member

@grvvy grvvy commented Jun 22, 2023

No description provided.

@grvvy grvvy requested review from antoinevg, miek and mossmann June 27, 2023 19:22
@mossmann
Copy link
Member

mossmann commented Sep 13, 2023 •
edited
Loading

I would like this to list authors as:
authors = ["Great Scott Gadgets <[email protected]>"]

@mossmann
Copy link
Member

also use 0.2.0 for the version

@miek
Copy link
Member

miek commented Oct 3, 2023

I've rebased, squashed, and made the changes requested.
I've also modified dep to match upstream (for the same reason as in 8594e4c) and changed the requires-python to match amaranth's, which fixes install with pdm (pdm install -G dev; pdm run applets/interactive-test.py should just work).

@miek miek marked this pull request as ready for review October 3, 2023 15:09
antoinevg
antoinevg approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@antoinevg antoinevg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mossmann
mossmann approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@mossmann mossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@miek miek merged commit e0f9fea into greatscottgadgets:main Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossmann mossmann mossmann approved these changes

@miek miek miek approved these changes

@antoinevg antoinevg antoinevg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grvvy @mossmann @miek @antoinevg