-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update analyzer descriptors and request handling #87
Update analyzer descriptors and request handling #87
Conversation
Just realised that the bcdVersion usage here isn't consistent with Apollo. Cynthion r1.4 should be encoded as |
ca062a3
to
1ab3fc5
Compare
Fixed. Now stores the version as a tuple on the platforms, and converts to the appropriate form when setting bcdDevice. |
1ab3fc5
to
edf9a51
Compare
Rebased now that #86 is merged, so that bInterfaceProtocol version starts at 0x00. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR updates the analyzer gateware's descriptors and request handling as per recent discussions.
The changes are as follows:
Device descriptor:
LUNA
toCynthion Project
.Interface descriptor:
cynthion.shared
.Request handler:
Corresponding Packetry support is in greatscottgadgets/packetry#93.