Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analyzer descriptors and request handling #87

Merged
merged 6 commits into from
May 16, 2024

Conversation

martinling
Copy link
Member

@martinling martinling commented May 15, 2024

This PR updates the analyzer gateware's descriptors and request handling as per recent discussions.

The changes are as follows:

Device descriptor:

  • Changed manufacturer string from LUNA to Cynthion Project.
  • Set serial string from ECP5 configuration flash ID.
  • Set bcdVersion to platform version rather than analyzer protocol version.

Interface descriptor:

  • Set bInterfaceClass to 0xFF (vendor specific).
  • Set bInterfaceSubclass and bInterfaceProtocol to values specified in cynthion.shared.

Request handler:

  • Now accepts requests with the recipient as the interface, rather than the device.

Corresponding Packetry support is in greatscottgadgets/packetry#93.

@martinling
Copy link
Member Author

Just realised that the bcdVersion usage here isn't consistent with Apollo. Cynthion r1.4 should be encoded as 1.04, not 1.40. I'll fix that.

@martinling martinling marked this pull request as draft May 15, 2024 11:18
@martinling martinling force-pushed the analyzer-descriptors branch from ca062a3 to 1ab3fc5 Compare May 15, 2024 12:20
@martinling
Copy link
Member Author

Fixed. Now stores the version as a tuple on the platforms, and converts to the appropriate form when setting bcdDevice.

@martinling martinling marked this pull request as ready for review May 15, 2024 12:31
@martinling martinling mentioned this pull request May 15, 2024
@martinling martinling force-pushed the analyzer-descriptors branch from 1ab3fc5 to edf9a51 Compare May 15, 2024 12:41
@martinling
Copy link
Member Author

Rebased now that #86 is merged, so that bInterfaceProtocol version starts at 0x00.

Copy link
Member

@antoinevg antoinevg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antoinevg antoinevg merged commit 84b1a57 into greatscottgadgets:main May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants