Faststream docs #403
Draft
Faststream docs #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 10 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
TrangPham
reviewed
Aug 21, 2024
| @@ -191,7 +191,9 @@ class GXAgent: | |||
| _PYPI_GX_AGENT_PACKAGE_NAME = "great_expectations_cloud" | |||
| _PYPI_GREAT_EXPECTATIONS_PACKAGE_NAME = "great_expectations" | |||
|
|
|||
| def __init__(self: Self): | |||
| def __init__(self: Self, app: FastStream, broker: RabbitBroker) -> None: | |||
There was a problem hiding this comment.
This is a breaking change for runner.
There was a problem hiding this comment.
Just discovered the Faststream app exposes a .broker attribute, so we don't need to inject app + broker, app by itself is enough.
There was a problem hiding this comment.
@TrangPham
Also, I think I see how to make this not breaking, but I didn't have a chance to implement it today.
I'll try to push it in the morning.
Kilo59
commented
Aug 22, 2024
asyncapi.yaml
Outdated
There was a problem hiding this comment.
To see what these docs would look like live, go to the asyncapi studio and paste them into the editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate AsyncAPI docs from the Faststream App.