-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(newsletter): clean up formatting and verbiage of existing documentation #3002
Conversation
@griest024 there seemed to be some duplicating information so I tried my best to clean it up and remove what I thought was redundant information. Can you review and make sure I didn't remove important information? |
libs/newsletter/README.md
Outdated
## Setting up your AppModule | ||
Install with yarn: | ||
``` | ||
yarn add @daffodil/newsletter @daffodil/core @ngrx/store @ngrx/effects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extraneous packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
835c8b5
to
92a9911
Compare
92a9911
to
8222331
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Part of: #2694
What is the new behavior?
Does this PR introduce a breaking change?
Other information