Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return more specific error message for unimplemented grpc methods #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return more specific error message for unimplemented grpc methods #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions trail/trail.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,14 @@ func FromGRPC(err error, args ...interface{}) error {
code := grpc.Code(err)
message := grpc.ErrorDesc(err)
var e error
const notImplementedMessage = "This server does not implement this feature yet. " +
"Likely the client version you are using is newer than the server. " +
"The server version: %v, the client version: %v. Please upgrade the server or downgrade the client."
switch code {
case codes.OK:
return nil
case codes.NotFound:
e = &trace.NotFoundError{Message: message}
e = &trace.NotFoundError{Message: notImplementedMessage}
case codes.AlreadyExists:
e = &trace.AlreadyExistsError{Message: message}
case codes.PermissionDenied:
Expand All @@ -136,7 +139,7 @@ func FromGRPC(err error, args ...interface{}) error {
case codes.Unavailable:
e = &trace.ConnectionProblemError{Message: message}
case codes.Unimplemented:
e = &trace.NotImplementedError{Message: message}
e = &trace.NotImplementedError{Message: notImplementedMessage}
default:
e = errors.New(message)
}
Expand Down