docs: update managed dbs #48725
Open
docs: update managed dbs #48725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevenGravy
commented
Nov 9, 2024
•
stevenGravy
commented
- reordered for mongdb atlas and snowflake to start Teleport db service after db can accept connections. otherwise this will add db services that won't work to start.
- mongodb atlas updated to include k8s setup
stevenGravy
added
no-changelog
github-actions
bot
requested review from
greedy52,
mmcallister,
ptgott,
r0mant,
xinding33 and
zmb3
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
🤖 Vercel preview here: https://docs-uvn9nbvii-goteleport.vercel.app/docs/ver/preview |
ptgott
reviewed
Nov 11, 2024
|
|
||
| (!docs/pages/includes/kubernetes-access/helm/helm-repo-add.mdx!) | ||
|
|
||
| (!docs/pages/includes/database-access/db-helm-install.mdx dbName="mongodb-atlas" dbProtocol="mongodb" databaseAddress="mongodb+srv://cluster0.abcde.mongodb.net" !) |
There was a problem hiding this comment.
I think we should change this partial so it doesn't include tabs. Otherwise, we get a nested Tabs component, which is a poor user experience.
greedy52
approved these changes
Nov 11, 2024
stevenGravy
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
|
Amplify deployment status
|
ptgott
reviewed
Jan 6, 2025
docs/pages/enroll-resources/database-access/enroll-managed-databases/snowflake.mdx
Outdated
Show resolved
Hide resolved
docs/pages/enroll-resources/database-access/enroll-managed-databases/snowflake.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| (!docs/pages/includes/kubernetes-access/helm/helm-repo-add.mdx!) | ||
|
|
||
| (!docs/pages/includes/database-access/db-helm-install.mdx dbName="example-snowflake" dbProtocol="snowflake" databaseAddress="abc12345.snowflakecomputing.com" !) |
There was a problem hiding this comment.
This partial also includes a Tabs component, leading to more nested tabs. Since the two tab items are nearly identical, I think it would make sense to use variables where the values differ between tabs and explain the user how to assign values.
Co-authored-by: Paul Gottschling <[email protected]>
stevenGravy
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.