Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add __directive meta field parallel to __type #1114

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yaacovCR
Copy link
Contributor

Use case: inquiring about specific directives such as @defer and @stream

@yaacovCR yaacovCR changed the title add __directive meta field parallel to type add __directive meta field parallel to __type Sep 25, 2024
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 2196942
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/66f401a944072500083a7389
😎 Deploy Preview https://deploy-preview-1114--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Thanks @benjie

Co-authored-by: Benjie <[email protected]>
as we haven't yet introduced the schema so nullable types might be confusing
@yaacovCR
Copy link
Contributor Author

Implemented by graphql/graphql-js#4203

@benjie
Copy link
Member

benjie commented Nov 7, 2024

I've not reviewed if these spec changes are sufficient, but I'm supportive of the aim 👍

@benjie benjie added the 💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md) label Nov 7, 2024
@yaacovCR
Copy link
Contributor Author

yaacovCR commented Nov 8, 2024

This was discussed at the November 2024 WG => this small change prompted an interesting discussion about "The Future of Introspection."

To my understanding, @leebyron 's feedback:

Perhaps __type should have always been nested as a type argument under __schema, so that similarly __directive should be nested as directive under __schema.

This general change might unlock general __schema arguments like:

  __schema(includeDeprecated: true) { ... }

that would apply to all nested fields.

As this change is not a "must-have" it will probably be paused to make sure it fits into whatever introspection future is planned. We do not have to actually implement that entire new future to move forward with this small feature change, but we have to make sure that this smaller change aligns with the plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants