Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Throw errors on specific graphql error messages #638

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

madumas
Copy link

@madumas madumas commented Apr 2, 2023

Indexer-service presently does not validate the responses from graph-node and forwards them directly to the gateways. The gateway will run its own validation and may find errors in the response and consider the query response incorrect. These conditions are not visible to indexer operator.

This PR logs at the WARN level graph-node responses that contain errors messages. If one of these messages contain one of the throwableErrors defined, a throw happens, which will ensure that the failed query will be logged at a higher level, and reported in the monitoring metrics.

To avoid putting too much strain on the CPU and affecting the performance, only small graphql responses are parsed and analyzed, assuming that larger responses indicate a successful query.

fixes #629

@madumas madumas changed the title Throw errors on specific graphql error messages Fix: Throw errors on specific graphql error messages Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🛑 Blocked
Development

Successfully merging this pull request may close these issues.

Failed graphql query reported as successful
1 participant