Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: tone down subgraph height violation message #1040

Merged
merged 1 commit into from
Nov 12, 2024
Merged

common: tone down subgraph height violation message #1040

merged 1 commit into from
Nov 12, 2024
+1 −1

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Nov 11, 2024

No description provided.

@fordN fordN changed the title chore: tone down subgraph height violation message common: tone down subgraph height violation message Nov 11, 2024
@fordN
Copy link
Contributor

fordN commented Nov 11, 2024

Thanks @tomasztrzos.

Few requests before we merge:

  • Can you squash to 1 commit?
  • Can you use our commit message format? Start with the effected package and then the message like: "common: tone down subgraph block height log message"

@tmigone
Copy link
Contributor Author

tmigone commented Nov 12, 2024

@fordN done!

fordN
fordN approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dwerner dwerner merged commit f697537 into main Nov 12, 2024
9 checks passed
@dwerner dwerner deleted the tmigone/subgraph-height branch November 12, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fordN fordN fordN approved these changes

@dwerner dwerner dwerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmigone @fordN @dwerner