Fix BigInt remote object parsing #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
add/array-parsing
branch
from
6754215 to
9520f70
Compare
ankur22
force-pushed
the
add/array-parsing
branch
from
9520f70 to
786b0b8
Compare
3 tasks
ankur22
force-pushed
the
fix/panic-parse-remote-obj
branch
2 times, most recently
from
dbb0981 to
1a76aec
Compare
ankur22
force-pushed
the
add/array-parsing
branch
from
786b0b8 to
5561e9e
Compare
ankur22
added a commit
that referenced
this pull request
Dec 15, 2023
Resolves: #1133 (comment) Resolves: #1133 (comment)
ankur22
force-pushed
the
add/array-parsing
branch
from
999704b to
133793b
Compare
inancgumus
approved these changes
Dec 15, 2023
This integration test will evaluate objects which uses the existing valueFromRemoteObject function in remote_object and not the latest parseConsoleRemoteObject function. In this change there are 3 commented out sub tests, 2 of which will be fixed, and 1 will remain commented out until a fix for the linked issue has been resolved.
For an unknown reason BigInt can't be parsed and is being set as a UnserializableValue. To ensure that we parse it correctly to an int we need to catch this case when dealing with other UnserializableValue.
Resolves: #1133 (comment) Resolves: #1133 (comment)
Co-authored-by: İnanç Gümüş <[email protected]>
ankur22
force-pushed
the
add/array-parsing
branch
from
133793b to
feafa26
Compare
ankur22
added a commit
that referenced
this pull request
Dec 15, 2023
Resolves: #1133 (comment) Resolves: #1133 (comment)
ankur22
added a commit
that referenced
this pull request
Dec 18, 2023
Resolves: #1133 (comment) Resolves: #1133 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This ensures that BigInt remote objects are parsed.
Why?
For an unknown reason BigInts are being set as
UnserializableValueinstead of the expectedValue. This ensures that we correctly deal with the case of BigInt when it is aUnserializableValue.Checklist
Related PR(s)/Issue(s)
Updates: #987