Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admission webhook: Undo prepare-shutdown calls if last-downscale fails to store #151

Merged
merged 13 commits into from
Jun 21, 2024
Merged

Admission webhook: Undo prepare-shutdown calls if last-downscale fails to store #151

merged 13 commits into from
Jun 21, 2024

Conversation

seizethedave
Copy link
Contributor

@seizethedave seizethedave commented May 31, 2024 •
edited
Loading

Fix a snag found in #146 where if the "downscaled" annotation/configmap fails to persist, the scale operation is denied, but the pods are not informed via DELETE that they should no longer shutdown.

@seizethedave seizethedave marked this pull request as ready for review June 4, 2024 22:25
@seizethedave seizethedave changed the title Undo prepare-shutdown calls if annotation fails. Admission webhook: Undo prepare-shutdown calls if last-downscale fails to store Jun 4, 2024
@seizethedave seizethedave requested a review from pr00se June 4, 2024 23:22
pr00se
pr00se reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@pr00se pr00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions, but overall LGTM

pkg/admission/prep_downscale.go Outdated Show resolved Hide resolved
pkg/admission/prep_downscale.go Show resolved Hide resolved
pkg/admission/zone_tracker.go Outdated Show resolved Hide resolved
pkg/admission/prep_downscale_test.go Outdated Show resolved Hide resolved
pkg/admission/prep_downscale_test.go Outdated Show resolved Hide resolved
@seizethedave seizethedave requested a review from pr00se June 18, 2024 22:12
@seizethedave
Copy link
Contributor Author

Thanks for the read.

pr00se
pr00se approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@pr00se pr00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@seizethedave seizethedave merged commit dddb21d into main Jun 21, 2024
6 checks passed
@seizethedave seizethedave deleted the davidgrant/prep-shutdown-zonetracker branch June 21, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pr00se pr00se pr00se approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seizethedave @pr00se