feat(distributor): add experimental memberlist kvStore for ha_tracker
#10054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAnge
force-pushed
the
nickange/ha_tracker/enable_memberlist_experimental
branch
from
2d750f1 to
3b2f0db
Compare
NickAnge
force-pushed
the
nickange/ha_tracker/enable_memberlist_experimental
branch
from
3b2f0db to
3b4d8c7
Compare
NickAnge
commented
Dec 3, 2024
| @@ -1023,6 +1023,7 @@ func (t *Mimir) initMemberlistKV() (services.Service, error) { | |||
| // Append to the list of codecs instead of overwriting the value to allow third parties to inject their own codecs. | |||
| t.Cfg.MemberlistKV.Codecs = append(t.Cfg.MemberlistKV.Codecs, ring.GetCodec()) | |||
| t.Cfg.MemberlistKV.Codecs = append(t.Cfg.MemberlistKV.Codecs, ring.GetPartitionRingCodec()) | |||
| t.Cfg.MemberlistKV.Codecs = append(t.Cfg.MemberlistKV.Codecs, distributor.GetReplicaDescCodec()) | |||
There was a problem hiding this comment.
FYI: Without adding the ReplicaDescCodec and initializing the singleton for HATrackerConfig.KVStore.MemberlistKV, it throws a panic error when using memberlist as a KV store.
Validated locally
NickAnge
force-pushed
the
nickange/ha_tracker/enable_memberlist_experimental
branch
from
94e86e8 to
bc877f8
Compare
|
The CHANGELOG has just been cut to prepare for the next release. Please rebase |
NickAnge
force-pushed
the
nickange/ha_tracker/enable_memberlist_experimental
branch
from
027b70f to
5cd0b8f
Compare
dimitarvdimitrov
deleted the
nickange/ha_tracker/enable_memberlist_experimental
branch
bjorns163
pushed a commit
to bjorns163/mimir
that referenced
this pull request
Dec 30, 2024
…er (grafana#10054) * feat(distributor): add experimental `memberlist` kvStore for ha_tracker * enable memberlistKV singleton and add ReplicaDesc Codec * docs: add experimental information * docs: address PR comments * add information about non provided cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR enables
experimentalmemberlistkvStore for the ha_tracker. We can change memberlist parameters through-memberlist-*flagWhich issue(s) this PR fixes or relates to
Part of https://github.com/grafana/pir-actions/issues/94
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.