fix: prevent fast ascii comparison if char is not letter #15774
+196
−85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The current
containsLower
implementation would only work for letters, as thec != s && c+'a'-'A' != s && c != s+'a'-'A'
would never work comparing|
against\
, for example. That will be the case if simple case insensitive regex filters, like|= `(?i)\|`
, that should only match against strings that contain|
.This added letter check makes the benchmark worse, but still better than the old version before #15076 was introduced. Maybe there are other ideas of improving?