Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't send empty aggregated metric payloads #15756

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

Prevent the pattern ingester from sending empty aggregated metric payloads when there are no aggregated metrics to send.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney marked this pull request as ready for review January 14, 2025 23:36
@trevorwhitney trevorwhitney requested a review from a team as a code owner January 14, 2025 23:36
@trevorwhitney trevorwhitney merged commit 86d50ad into main Jan 15, 2025
61 checks passed
@trevorwhitney trevorwhitney deleted the fix-empty-agg-metric-payloads branch January 15, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants