Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: broken URLs fixed #15726

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

myrkytyn
Copy link
Contributor

What this PR does / why we need it:
This PR fixes the broken links in Loki documentation.

Which issue(s) this PR fixes:
Fixes broken links in Loki documentation.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@myrkytyn myrkytyn requested a review from a team as a code owner January 13, 2025 22:30
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jan 13, 2025
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM, thanks for catching these!

@JStickler JStickler merged commit 9e617ec into grafana:main Jan 13, 2025
62 checks passed
loki-gh-app bot pushed a commit that referenced this pull request Jan 13, 2025
(cherry picked from commit 9e617ec)
loki-gh-app bot pushed a commit that referenced this pull request Jan 13, 2025
(cherry picked from commit 9e617ec)
loki-gh-app bot pushed a commit that referenced this pull request Jan 13, 2025
(cherry picked from commit 9e617ec)
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Jan 13, 2025

The backport to release-3.0.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-15726-to-release-3.0.x origin/release-3.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 9e617ecb092beae9547ec055ba66d15a3e337088

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-15726-to-release-3.0.x
# Create the PR body template
PR_BODY=$(gh pr view 15726 --json body --template 'Backport 9e617ecb092beae9547ec055ba66d15a3e337088 from #15726{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'docs: broken URLs fixed (backport release-3.0.x)' --body-file - --label 'size/XS' --label 'type/docs' --label 'backport' --base release-3.0.x --milestone release-3.0.x --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-15726-to-release-3.0.x

# Create a pull request where the `base` branch is `release-3.0.x` and the `compare`/`head` branch is `backport-15726-to-release-3.0.x`.

# Remove the local backport branch
git switch main
git branch -D backport-15726-to-release-3.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x backport release-3.3.x backport-failed size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants