Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update _index.md #fix typos #14608

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

Piyush-r-bhaskar
Copy link
Contributor

@Piyush-r-bhaskar Piyush-r-bhaskar commented Oct 24, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Piyush-r-bhaskar Piyush-r-bhaskar requested a review from a team as a code owner October 24, 2024 17:35
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 24, 2024
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@JStickler
Copy link
Contributor

@Piyush-r-bhaskar Please sign the CLA so that I can merge this.

@JStickler JStickler changed the title Update _index.md #fix typos docs: Update _index.md #fix typos Oct 24, 2024
@JStickler JStickler merged commit 7965722 into grafana:main Oct 24, 2024
63 checks passed
loki-gh-app bot pushed a commit that referenced this pull request Oct 24, 2024
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Oct 24, 2024

The backport to release-3.1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14608-to-release-3.1.x origin/release-3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 7965722bb5a4f31cc68d30be0290e529c9aafe96

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-14608-to-release-3.1.x
# Create the PR body template
PR_BODY=$(gh pr view 14608 --json body --template 'Backport 7965722bb5a4f31cc68d30be0290e529c9aafe96 from #14608{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'docs: Update _index.md #fix typos (backport release-3.1.x)' --body-file - --label 'size/XS' --label 'type/docs' --label 'backport' --base release-3.1.x --milestone release-3.1.x --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-14608-to-release-3.1.x

# Create a pull request where the `base` branch is `release-3.1.x` and the `compare`/`head` branch is `backport-14608-to-release-3.1.x`.

# Remove the local backport branch
git switch main
git branch -D backport-14608-to-release-3.1.x

loki-gh-app bot pushed a commit that referenced this pull request Oct 24, 2024
JStickler pushed a commit that referenced this pull request Oct 24, 2024
@Piyush-r-bhaskar Piyush-r-bhaskar deleted the patch-1 branch October 24, 2024 18:22
JStickler added a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x backport-failed size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants