Skip to content

Commit

Permalink
chore(dataobj): use logproto.Stream for single append
Browse files Browse the repository at this point in the history
  • Loading branch information
rfratto committed Jan 15, 2025
1 parent 79f24d0 commit d79a324
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pkg/dataobj/dataobj.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (

"github.com/thanos-io/objstore"

"github.com/grafana/loki/pkg/push"
"github.com/grafana/loki/v3/pkg/logproto"
)

// BuilderConfig configures a data object [Builder].
Expand All @@ -30,14 +30,14 @@ func NewBuilder(cfg BuilderConfig, bucket objstore.Bucket, tenantID string) *Bui
return &Builder{}
}

// Append buffers an entry to be written to a data object. If the Builder is
// Append buffers a stream to be written to a data object. If the Builder is
// full, Append returns false without appending the entry.
//
// Once a Builder is full, call [Builder.Flush] to flush the buffered data,
// then call Append again with the same entry.
func (b *Builder) Append(entry push.PushRequest) bool {
func (b *Builder) Append(stream logproto.Stream) bool {
// TODO(rfratto): implement
_ = entry
_ = stream
return true
}

Expand Down

0 comments on commit d79a324

Please sign in to comment.