Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: disable tests to make CI green #4211

Merged
merged 2 commits into from
Jan 21, 2025
Merged

grpc: disable tests to make CI green #4211

merged 2 commits into from
Jan 21, 2025

Conversation

mstoykov
Copy link
Contributor

What?

Disable tests so that they do not fail after recent security update

Why?

CI being red is pretty bad, and this doesn't seem to have an easy fix.

The real fix will likely require
#3549
or something similar as the problems appears to be the update of the test certificates.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

The real fix will likely require
#3549
or something similar as the problems appears to be the update of the
test certificates.
@mstoykov mstoykov added this to the v0.57.0 milestone Jan 21, 2025
@mstoykov mstoykov requested a review from a team as a code owner January 21, 2025 13:17
@mstoykov mstoykov requested review from olegbespalov and joanlopez and removed request for a team January 21, 2025 13:17
oleiade
oleiade previously approved these changes Jan 21, 2025
olegbespalov
olegbespalov previously approved these changes Jan 21, 2025
@mstoykov mstoykov dismissed stale reviews from olegbespalov and oleiade via 4d6d025 January 21, 2025 13:23
@mstoykov mstoykov merged commit aae6ef2 into master Jan 21, 2025
28 of 29 checks passed
@mstoykov mstoykov deleted the greenCI branch January 21, 2025 13:34
mstoykov added a commit that referenced this pull request Jan 21, 2025
mstoykov added a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants