Add resource_type tag #4140
Merged
Add resource_type tag #4140
+111
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
requested review from
inancgumus and
joanlopez
and removed request for
a team
ankur22
commented
Dec 19, 2024
| @@ -180,6 +180,7 @@ func (m *NetworkManager) emitRequestMetrics(req *Request) { | |||
| if state.Options.SystemTags.Has(k6metrics.TagURL) { | |||
| tags = handleURLTag(m.mi, req.URL(), req.method, tags) | |||
| } | |||
| tags = tags.With("resource_type", req.ResourceType()) | |||
There was a problem hiding this comment.
There are two things that I'm not sure of:
- This isn't a system tag, but should it be?
- This list can change at a moments notice by the chrome team, should we map them from the chrome ResourceType to a k6 version of it. We would be able to detect if we stop matching on any of the types and log a warning, plus create a unit test to catch this as early as possible.
There was a problem hiding this comment.
We would be able to detect if we stop matching on any of the types and log a warning, plus create a unit test to catch this as early as possible.
This sounds like the way to go! 👍🏻
There was a problem hiding this comment.
I've added a way to validate the ResourceTypes.
ankur22
force-pushed
the
add/resource-type-tag
branch
2 times, most recently
from
dafc212 to
0f7b08a
Compare
mstoykov
approved these changes
Dec 20, 2024
joanlopez
approved these changes
Jan 3, 2025
A new resource_type tag is being added to allow users to view and filter metrics based on the chrome resource_types.
It's a duplicate of CDP's network.ResourceType.
ankur22
force-pushed
the
add/resource-type-tag
branch
from
0f7b08a to
a573f2c
Compare
oleiade
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A new
resource_typetag is being added to allow users to view and filter metrics based on the chrome resource types, which are currently defined as:Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Linked: grafana/xk6-browser#1551