Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sobek to fix usage of class if it is exported as default #3891

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Update sobek to fix usage of class if it is exported as default #3891

merged 1 commit into from
Aug 8, 2024

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Aug 8, 2024 •
edited
Loading

What?

Update sobek

Why?

Fixes export default class m not being usable as new m in the same file it was defined.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov requested a review from a team as a code owner August 8, 2024 08:52
@mstoykov mstoykov requested review from codebien and olegbespalov and removed request for a team August 8, 2024 08:52
@mstoykov mstoykov added the bug label Aug 8, 2024
@mstoykov mstoykov added this to the v0.53.0 milestone Aug 8, 2024
@mstoykov mstoykov requested a review from joanlopez August 8, 2024 08:58
@mstoykov mstoykov merged commit 869b168 into master Aug 8, 2024
22 of 23 checks passed
@mstoykov mstoykov deleted the updateSobek branch August 8, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanlopez joanlopez joanlopez approved these changes

@codebien codebien codebien approved these changes

@olegbespalov olegbespalov Awaiting requested review from olegbespalov olegbespalov is a code owner automatically assigned from grafana/k6-core

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.53.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @codebien @joanlopez