Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Oleg Bespalov <[email protected]>
  • Loading branch information
mstoykov and olegbespalov authored Jul 19, 2024
1 parent d5f1059 commit d89bf0c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/tc39/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Introduction to a k6's TC39 testing

The point of this module is to test k6 Sobek and k6 Sobek+esbuild combo against the tc39 test suite.
This module tests k6 [Sobek](https://github.com/grafana/sobek) and the k6 Sobek+esbuild combo against the tc39 test suite.

Ways to use it:
1. run ./checkout.sh to checkout the last commit sha of [test262](https://github.com/tc39/test262)
Expand All @@ -27,6 +27,6 @@ This also means that, if the
previous breakage was something a user can work around in a certain way, it now might be something
else that the user can't workaround or have another problem.

Now that k6 doesn't use babel, it is mostly for testing esbuild, but also due to Sobek not testing a lot more stuff. It is still possible we might drop this whole package in the future.
Starting v0.53 k6 doesn't use babel, it is mostly for testing esbuild, but also due to Sobek not testing a lot more stuff. It is still possible that we drop this whole package in the future.

For these reasons, I decided that recording what breaks and checking that it doesn't change is better.

0 comments on commit d89bf0c

Please sign in to comment.