Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ivan <[email protected]>
  • Loading branch information
olegbespalov and codebien authored Oct 13, 2023
1 parent 75f526e commit b3705aa
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cloudapi/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ func GetConsolidatedConfig(
// we want to show a warning if the user is using the only old way of defining the config
if cloudConfig == nil && external != nil {
if _, ok := external[LegacyCloudConfigKey]; ok {
result.WarningMessage = "The options.ext.loadimpact option is deprecated, please use the a options.cloud instead"
result.WarningMessage = "The options.ext.loadimpact option is deprecated, please use options.cloud instead"
}
}

Expand Down Expand Up @@ -379,7 +379,7 @@ func mergeFromCloudOptionAndExternal(
// TODO: Fix this
// We reuse cloud.Config for parsing options.cloud (or legacy loadimpact struct), but this probably shouldn't be
// done, as the idea of options.ext is that they are extensible without touching k6. But in
// order for this to happen, we shouldn't actually marshall cloud.Config on top of it, because
// order for this to happen, we shouldn't actually marshal cloud.Config on top of it, because
// it will be missing some fields that aren't actually mentioned in the struct.
// So in order for use to copy the fields that we need for k6 cloud's api we unmarshal in
// map[string]interface{} and copy what we need if it isn't set already
Expand Down

0 comments on commit b3705aa

Please sign in to comment.