Skip to content

Add new release notes for v0.56.0 #4060

Add new release notes for v0.56.0

Add new release notes for v0.56.0 #4060

Triggered via pull request December 20, 2024 16:48
Status Failure
Total duration 3m 50s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 11 warnings
lint: js/modules/k6/browser/browser/browser_context_mapping.go#L149
Function `WaitForEvent->waitForEvent` should pass the context parameter (contextcheck)
lint: js/modules/k6/browser/browser/browser_context_mapping.go#L159
Function `mapPage->mapPage$1->mapPage$1$1->BringToFront` should pass the context parameter (contextcheck)
lint: js/modules/k6/browser/browser/registry.go#L250
Function `handleExitEvent->clear->Close` should pass the context parameter (contextcheck)
lint: js/modules/k6/browser/browser/registry.go#L272
Function `isBrowserIter` should pass the context parameter (contextcheck)
lint: js/modules/k6/browser/browser/registry.go#L287
Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
lint: js/modules/k6/browser/browser/registry.go#L320
Function `deleteBrowser->Close` should pass the context parameter (contextcheck)
lint: js/modules/k6/browser/browser/registry.go#L312
Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
lint: js/modules/k6/browser/browser/sync_browser_context_mapping.go#L73
Function `syncMapBrowserContext$3$1$1` should pass the context parameter (contextcheck)
lint: js/modules/k6/browser/browser/sync_browser_context_mapping.go#L95
Function `WaitForEvent->waitForEvent` should pass the context parameter (contextcheck)
lint: js/modules/k6/browser/browser/sync_browser_context_mapping.go#L105
Function `syncMapPage->syncMapPage$1` should pass the context parameter (contextcheck)
deps
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint: js/modules/k6/browser/keyboardlayout/layout.go#L9
exported: exported type KeyInput should have comment or be unexported (revive)
lint: js/modules/k6/browser/keyboardlayout/layout.go#L11
exported: exported type KeyDefinition should have comment or be unexported (revive)
lint: js/modules/k6/browser/keyboardlayout/layout.go#L22
exported: exported type KeyboardLayout should have comment or be unexported (revive)
lint: js/modules/k6/browser/log/logger.go#L15
exported: exported type Logger should have comment or be unexported (revive)
lint: js/modules/k6/browser/tests/ws/server.go#L239
unused-parameter: parameter 'conn' seems to be unused, consider removing or renaming it as _ (revive)
lint: js/modules/k6/browser/chromium/browser_type_test.go#L167
unused-parameter: parameter 'file' seems to be unused, consider removing or renaming it as _ (revive)
lint: js/modules/k6/browser/browser/registry_test.go#L197
unused-parameter: parameter 'key' seems to be unused, consider removing or renaming it as _ (revive)
lint: js/modules/k6/browser/common/hooks.go#L9
exported: exported type HookID should have comment or be unexported (revive)
lint: js/modules/k6/browser/common/hooks.go#L12
exported: exported const HookApplySlowMo should have comment (or a comment on this block) or be unexported (revive)
lint: js/modules/k6/browser/common/hooks.go#L15
exported: exported type Hook should have comment or be unexported (revive)