-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release v10.2.0 as latest #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also regenerate the other versions? This should only remove the withStyle
function.
Hmmm, it seems like it also changes the type annotations from - '#withName': { 'function': { args: [{ default: null, enums: null, name: 'value', type: 'string' }], help: '' } },
+ '#withName': { 'function': { args: [{ default: null, enums: null, name: 'value', type: ['string'] }], help: '' } }, |
Type was changed in #154, can you rebase? |
a11cb04
to
58ec2d8
Compare
regenerating is done, and as you said no changes but the removal of |
Ugh, sorry, #159 got merged and is causing a conflict. Can you rebase? |
local normalized = panelUtil.normalizeY(uncollapsed); | ||
|
||
std.map(function(p) p + { gridPos+: { y+: startY } }, normalized), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rebase change
fixes: #150
I had to uncomment
withStyle
as this doesn't exist anymore for v10.2.0 dashboards. This probably breaks backwards compatibility with previous versions. Do you have a better idea on how to handle that? I also had to switch the script fromjrsonnet
tojsonnet
since that tool had problems with theany
property in the custom boards. I am not sure if I was using simply the wrong tool or if there is something else going on. I can simply revert that specific commit if it is a problem on my side.I suggest to look commit-by-commit.
tools used: