Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows and macOS integration examples #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexwulf
Copy link

Added Windows and macOS integration examples to the existing configuration.

Added Windows and macOS integration examples to the existing configuration.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@theSuess theSuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've left some comments on the changes. Please also address the linting issues regarding the unnecessary escape characters

Comment on lines +165 to +171
prometheus.scrape "linux_node" {
targets = prometheus.exporter.unix.node.targets
forward_to = [
grafana_cloud.stack.receivers.metrics,
]
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this for the windows example

Suggested change
prometheus.scrape "linux_node" {
targets = prometheus.exporter.unix.node.targets
forward_to = [
grafana_cloud.stack.receivers.metrics,
]
}

job_name = "integrations/windows_exporter"
}
prometheus.relabel "integrations_windows_exporter" {
forward_to = [prometheus.remote_write.metrics_service.receiver]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
forward_to = [prometheus.remote_write.metrics_service.receiver]
forward_to = [grafana_cloud.stack.receivers.metrics]

}
}
loki.process "logs_integrations_windows_exporter_application" {
forward_to = [loki.write.grafana_cloud_loki.receiver]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
forward_to = [loki.write.grafana_cloud_loki.receiver]
forward_to = [grafana_cloud.stack.receivers.logs]

Comment on lines +287 to +292
prometheus.scrape "linux_node" {
targets = prometheus.exporter.unix.node.targets
forward_to = [
grafana_cloud.stack.receivers.metrics,
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prometheus.scrape "linux_node" {
targets = prometheus.exporter.unix.node.targets
forward_to = [
grafana_cloud.stack.receivers.metrics,
]
}

job_name = "integrations/node_exporter"
}
prometheus.relabel "integrations_node_exporter" {
forward_to = [prometheus.remote_write.metrics_service.receiver]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
forward_to = [prometheus.remote_write.metrics_service.receiver]
forward_to = [grafana_cloud.stack.receivers.metrics]

}]
}
loki.process "logs_integrations_integrations_node_exporter_direct_scrape" {
forward_to = [loki.write.grafana_cloud_loki.receiver]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
forward_to = [loki.write.grafana_cloud_loki.receiver]
forward_to = [grafana_cloud.stack.receivers.metrics]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants