-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows and macOS integration examples #12
base: main
Are you sure you want to change the base?
Conversation
Added Windows and macOS integration examples to the existing configuration.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I've left some comments on the changes. Please also address the linting issues regarding the unnecessary escape characters
prometheus.scrape "linux_node" { | ||
targets = prometheus.exporter.unix.node.targets | ||
forward_to = [ | ||
grafana_cloud.stack.receivers.metrics, | ||
] | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this for the windows example
prometheus.scrape "linux_node" { | |
targets = prometheus.exporter.unix.node.targets | |
forward_to = [ | |
grafana_cloud.stack.receivers.metrics, | |
] | |
} |
job_name = "integrations/windows_exporter" | ||
} | ||
prometheus.relabel "integrations_windows_exporter" { | ||
forward_to = [prometheus.remote_write.metrics_service.receiver] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forward_to = [prometheus.remote_write.metrics_service.receiver] | |
forward_to = [grafana_cloud.stack.receivers.metrics] |
} | ||
} | ||
loki.process "logs_integrations_windows_exporter_application" { | ||
forward_to = [loki.write.grafana_cloud_loki.receiver] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forward_to = [loki.write.grafana_cloud_loki.receiver] | |
forward_to = [grafana_cloud.stack.receivers.logs] |
prometheus.scrape "linux_node" { | ||
targets = prometheus.exporter.unix.node.targets | ||
forward_to = [ | ||
grafana_cloud.stack.receivers.metrics, | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prometheus.scrape "linux_node" { | |
targets = prometheus.exporter.unix.node.targets | |
forward_to = [ | |
grafana_cloud.stack.receivers.metrics, | |
] | |
} |
job_name = "integrations/node_exporter" | ||
} | ||
prometheus.relabel "integrations_node_exporter" { | ||
forward_to = [prometheus.remote_write.metrics_service.receiver] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forward_to = [prometheus.remote_write.metrics_service.receiver] | |
forward_to = [grafana_cloud.stack.receivers.metrics] |
}] | ||
} | ||
loki.process "logs_integrations_integrations_node_exporter_direct_scrape" { | ||
forward_to = [loki.write.grafana_cloud_loki.receiver] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forward_to = [loki.write.grafana_cloud_loki.receiver] | |
forward_to = [grafana_cloud.stack.receivers.metrics] |
Added Windows and macOS integration examples to the existing configuration.