Fetch Grafana version from /api/frontend/settings
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
force-pushed
the
support-aws-managed-grafana-version-fetching
branch
2 times, most recently
from
11fffe5
to
e8f243b
Compare
squadgazzz
commented
Sep 28, 2024
| if not isinstance(response, dict): | ||
| error = f"{error_template}: Invalid response, content was: {response}" | ||
|
|
||
| response = Munch(response) | ||
| response = response.get("buildInfo") |
There was a problem hiding this comment.
The whole response is quite large. It makes sense to return only basic buildInfo which contains similar to /api/health response data.
squadgazzz
force-pushed
the
support-aws-managed-grafana-version-fetching
branch
from
e8f243b
to
1b9ef80
Compare
squadgazzz
commented
Sep 28, 2024
| health = wtf.health | ||
| assert "commit" in health | ||
| assert "version" in health | ||
| assert health.database == "ok" |
There was a problem hiding this comment.
database status is not represented in the buildInfo response.
squadgazzz
changed the title
/api/frontend/settings/api/frontend/settings
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 87.21% 87.15% -0.06%
==========================================
Files 9 9
Lines 1079 1082 +3
==========================================
+ Hits 941 943 +2
- Misses 138 139 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Your improvement has been included into version 0.20.0, just released. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMG API doesn't contain
/api/healthendpoint, which makes it impossible to usegrafana-wtfwith this kind of setup.The proposal is to use
/api/frontend/settingsfor the same purpose, which works for both regular and AWS-managed Grafana versions.Fixes #141