Improve initial sync handling in headless mode #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some problems with IntelliJ 2023.2 where we didn't detect initial import.
asodja
force-pushed
the
asodja/better-headless-2023.2
branch
from
ed51441 to
82ba560
Compare
6hundreds
reviewed
Mar 11, 2024
| @@ -93,6 +93,7 @@ private List<String> getAdditionalJvmArgs() { | |||
| if (SHOULD_RUN_HEADLESS) { | |||
| systemProperties.put("java.awt.headless", "true"); | |||
| } | |||
| systemProperties.put("external.system.auto.import.disabled", "true"); | |||
There was a problem hiding this comment.
Does this line is still required, if we have this?
There was a problem hiding this comment.
Good point, you are right, we shouldn't handle it in two places. I think it's correct that we have this flag here before our plugin is loaded. We just need to remove it GradleProfilerClient since that is already too late. And we need to set this flag in unit tests too.
asodja
force-pushed
the
asodja/better-headless-2023.2
branch
2 times, most recently
from
179a62b to
82ba560
Compare
asodja
force-pushed
the
asodja/better-headless-2023.2
branch
from
184a6c2 to
4a90ea8
Compare
asodja
force-pushed
the
asodja/better-headless-2023.2
branch
from
5a542a7 to
83dacfc
Compare
6hundreds
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some problems with IntelliJ 2023.2 where we didn't detect initial import.