feat: set updates #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hagoptaminian
requested changes
Aug 10, 2024
There was a problem hiding this comment.
Hi @pyphilia this looks really nice. I left some comments mostly on (English) language improvements and a few small errors. I think the resolution/dimensions of education21 logo at the bottom are a bit off; maybe make it a bit smaller?
|
Thank you for the review! Could you provide a screenshot of the logo your mentioning? I think it has exactly the same dimensions as the others, but it has more margins within the image so it appears smaller. |
|
Hi @pyphilia
|
|
Which browser are you using? I don't see this effect And indeed, I think it was a typo, I changed the school name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.