-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Oracle GraalVM via GDS. #109
Conversation
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
10b2172
to
310e604
Compare
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
The two new jobs downloading Oracle GraalVM for JDK 17 and 17.0.2 are passing: |
src/graalvm.ts
Outdated
let javaVersion = javaVersionOrDev | ||
const toolName = determineToolName(javaVersion, false) | ||
if (javaVersionOrDev === '17' && !isTokenProvided) { | ||
core.warning( | ||
'This build uses the last update of Oracle GraalVM for JDK 17 under the GFTC. More details: https://github.com/marketplace/actions/github-action-for-graalvm#notes-on-oracle-graalvm-for-jdk-17.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This warning will be displayed for users using java-version: '17'
. The link should resolve to this section in the README: https://github.com/graalvm/setup-graalvm/pull/109/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R194
1614e43
to
d095e77
Compare
d095e77
to
abd21e7
Compare
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
GraalVM Native Image Build Report
Environment
Analysis Results
Image Details
Resource Usage
Report generated by setup-graalvm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for making the README clearer! That answers my questions from #107.
I have added some suggestions to these changes, hopefully they are useful. However, I cannot contribute them because I haven't signed the OCA.
This PR adds support for downloading Oracle GraalVM via GDS. With this, users can access Oracle GraalVM releases licensed under the GraalVM OTN License Including License for Early Adopter Versions (GOTN).
The PR also re-organizes and updates the main README.md and updates a dependency.