Skip to content

Commit

Permalink
Use -version on JDK 8. Fixes #86
Browse files Browse the repository at this point in the history
  • Loading branch information
fniephaus committed Feb 23, 2024
1 parent e878075 commit 3c67090
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
12 changes: 8 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,12 @@ jobs:
java-version: '17'
components: 'native-image'
os: ubuntu-20.04
- version: '21.2.0'
java-version: '8' # for JDK 8 notification
components: 'native-image'
os: ubuntu-latest
- version: '22.3.1'
java-version: '11' # for JDK11 notification
java-version: '11' # for JDK 11 notification
components: 'native-image'
os: macos-11
- version: '22.3.1'
Expand Down Expand Up @@ -132,8 +136,8 @@ jobs:
[[ "$GRAALVM_HOME" == *"$RUNNER_TOOL_CACHE"* ]] || exit 23
fi
echo "JAVA_HOME: $JAVA_HOME"
java --version
java --version | grep "GraalVM" || exit 34
java -version
java -version | grep "GraalVM" || exit 34
native-image --version
if [[ "${{ matrix.java-version }}" != "dev" ]]; then
gu list
Expand All @@ -143,7 +147,7 @@ jobs:
run: |
echo "GRAALVM_HOME: $env:GRAALVM_HOME"
echo "JAVA_HOME: $env:JAVA_HOME"
java --version
java -version
native-image --version
gu.cmd remove native-image
if: runner.os == 'Windows'
Expand Down
2 changes: 1 addition & 1 deletion dist/main/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ async function run(): Promise<void> {

core.startGroup(`Successfully set up '${basename(graalVMHome)}'`)
await exec(join(graalVMHome, 'bin', `java${c.EXECUTABLE_SUFFIX}`), [
'--version'
javaVersion.startsWith('8') ? '-version' : '--version'
])
core.endGroup()
} catch (error) {
Expand Down

0 comments on commit 3c67090

Please sign in to comment.