Fix SBOM integration test bug #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
rudsberg
commented
Jan 13, 2025
| then: | ||
| buildSucceeded | ||
| outputContainsPattern".*CycloneDX SBOM with \\d+ component\\(s\\) is embedded in binary \\(.*?\\)." | ||
| outputDoesNotContain "Use '--enable-sbom' to assemble a Software Bill of Materials (SBOM)" | ||
| validateSbom sbom |
There was a problem hiding this comment.
This was the culprit. The sbom JSON should not be created in this scenario since --enable-sbom gets used which only embeds the SBOM in the image.
melix
approved these changes
Jan 13, 2025
dnestoro
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a test failure identified by @dnestoro (see here). The issue was that the test incorrectly checked for an exported SBOM when only an embedded SBOM is generated. I believe the test previously did not fail since the exported SBOM was picked up from another test, but in the failed run that was not the case.