[CI] Include delimiter in job title when filtering issues #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Top leve jobs might share a common prefix, e.g. "Q main M24 latest" is shared in both linux and windows builds. Including the delimiter we ensure that we are getting the full top level job title and prevent false negatives in our reports.
oracle-contributor-agreement
bot
added
the
OCA Verified
zakkak
commented
Nov 21, 2024
| @@ -16,8 +16,9 @@ | |||
|
|
|||
| //usr/bin/env jbang "$0" "$@" ; exit $? | |||
|
|
|||
| //DEPS org.kohsuke:github-api:1.321 | |||
| //DEPS info.picocli:picocli:4.2.0 | |||
| //JAVA 21 | |||
There was a problem hiding this comment.
That's not mandatory for the changes, but there is also no reason to support older versions.
jerboaa
approved these changes
Nov 21, 2024
Comment on lines
-260
to
+270
| Object oldIssue = issues.put(issue, job.getName().split(" / ")[0]); | ||
| Object oldIssue = issues.put(issue, job.getName().split(JOB_TITLE_DELIMITER)[0]); |
There was a problem hiding this comment.
OK, so this solves the "common prefix" problem by including the delimiter for "Linux" jobs, correct?
I.e. Q main M 24 latest windows / Mandrel build no longer is matched by prefix Q main M 24 latest / , which would have been the case when the prefix previously was Q main M 24 latest (without the positive look behind match).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top level jobs might share a common prefix, e.g. "Q main M24 latest" is shared in both linux and windows builds. Including the delimiter we ensure that we are getting the full top level job title and prevent false negatives in our reports.
Also updates quarkus-ecosystem-issue.java script dependencies
Resolves issue observed in #755 (comment)