Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use option --jmods-dir NO_JMODS for Mandrel based on JDK 24 #466

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jerboaa
Copy link
Collaborator

@jerboaa jerboaa commented Nov 26, 2024

@jerboaa
Copy link
Collaborator Author

jerboaa commented Nov 26, 2024

CI currently fails due to NO_JMODS not being appropriately interpreted. I'll only integrate once all the deps are in place.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Dec 3, 2024

Re-running all jobs now that dependent PRs are in. Lets see how that goes.

@jerboaa jerboaa requested a review from zakkak December 3, 2024 09:44
@jerboaa
Copy link
Collaborator Author

jerboaa commented Dec 3, 2024

Hmm, something is still not quite right. Investigating...

@jerboaa
Copy link
Collaborator Author

jerboaa commented Dec 3, 2024

OK, CI used 645d27a7cf8953a5a2904c0e726ba3630be85fd8 which doesn't have oracle/graal@7d964fa. I'll manually sync graal/master and will try again.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Dec 3, 2024

OK, CI used 645d27a7cf8953a5a2904c0e726ba3630be85fd8 which doesn't have oracle/graal@7d964fa. I'll manually sync graal/master and will try again.

Sync job: https://github.com/graalvm/mandrel/actions/runs/12130475478 which brought it up to upstream master tip which currently is 36c69edf65ee12a5e43b721c7f4813419c279b63. The re-triggered jobs should now work (provided JDK 24+26 EA builds are OK; I've tested with JDK 24+25).

OK failure is now due to a missing JVM CI update to bump to 24+26 as it fails at native image agent generation:

 ========================================================================================================================
GraalVM Native Image: Generating 'libnative-image-agent' (shared library)...
========================================================================================================================
For detailed information and explanations on the build output, visit:
https://github.com/oracle/graal/blob/master/docs/reference-manual/native-image/BuildOutput.md
------------------------------------------------------------------------------------------------------------------------

[1/8] Initializing...                                                                                    (0.0s @ 0.07GB)
Error: Type mismatch:
    class com.oracle.svm.core.jdk.Target_java_security_Provider_ServiceKey private static com.oracle.svm.core.jdk.Target_java_security_Provider_ServiceKey com.oracle.svm.core.jdk.Target_java_security_Provider.previousKey
    class java.lang.ThreadLocal private static final java.lang.ThreadLocal java.security.Provider.previousKey
------------------------------------------------------------------------------------------------------------------------
                         0.1s (3.3% of total time) in 8 GCs | Peak RSS: 0.34GB | CPU load: 3.25
========================================================================================================================
Failed generating 'libnative-image-agent' after 2.0s.
Exception in thread "main" java.lang.RuntimeException: java.lang.RuntimeException: Failed, exit code: 1
	at OperatingSystem.exec(build.java:1874)
	at build.buildAgents(build.java:304)
	at build.main(build.java:247)
Caused by: java.lang.RuntimeException: Failed, exit code: 1
	at OperatingSystem.exec(build.java:1863)
	at build.buildAgents(build.java:304)
	at build.main(build.java:247)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at jdk.compiler/com.sun.tools.javac.launcher.SourceLauncher.execute(SourceLauncher.java:269)
	at jdk.compiler/com.sun.tools.javac.launcher.SourceLauncher.run(SourceLauncher.java:153)
	at jdk.compiler/com.sun.tools.javac.launcher.SourceLauncher.main(SourceLauncher.java:78)

Edit: This affects Linux, Windows, Mac all in the same way.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Dec 3, 2024

The 2-step build builds the jars fine:

INFO [build] Congratulations you successfully built Mandrel 10.9.8.7-dev based on Java 24-beta+26-ea

The native bits is what's failing. @zakkak Could you please review this so that we can get past graalvm/mandrel#808, thanks!

Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @jerboaa!

Regarding the 24+26 related failures oracle/graal#10216 should fix them.

@zakkak zakkak merged commit 148e035 into graalvm:master Dec 3, 2024
1 of 6 checks passed
@jerboaa
Copy link
Collaborator Author

jerboaa commented Dec 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraalVM for JDK 24] Add support for building based on a JDK that has JEP 493 enabled
2 participants