-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use option --jmods-dir NO_JMODS for Mandrel based on JDK 24 #466
Conversation
CI currently fails due to |
Re-running all jobs now that dependent PRs are in. Lets see how that goes. |
Hmm, something is still not quite right. Investigating... |
OK, CI used |
Sync job: https://github.com/graalvm/mandrel/actions/runs/12130475478 which brought it up to upstream master tip which currently is OK failure is now due to a missing JVM CI update to bump to
Edit: This affects Linux, Windows, Mac all in the same way. |
The 2-step build builds the jars fine:
The native bits is what's failing. @zakkak Could you please review this so that we can get past graalvm/mandrel#808, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @jerboaa!
Regarding the 24+26 related failures oracle/graal#10216 should fix them.
Thanks! |
This change is contingent on two dependency PRs:
mx
: Enable build support for JEP 493 enabled base JDKs mx#287oracle/graal
: [GR-60173] Register custom module-info compilation participant for JDK builds without JMODs oracle/graal#10161Closes: graalvm/mandrel#808