[24.0] Backport: Better handling of MANIFEST.MF attributes #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the build script would add these two attributes irrespective whether or not they'd exist in the Graal artefacts: Specification-Version Implementation-Version With this patch, only updates to the Implementation-Version attribute are done based on the maven version in use. Specification-Version is only added if it's not yet there in a jar or source jar file. Closes: Karm/mandrel-integration-tests#270 (cherry picked from commit 48c154e)
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@zakkak Since we need it in 24.0, we probably also need it in 24.1. Otherwise, we'd have 24.0 and 24.2 fixed and 24.1 not. |
|
@jerboaa In 24.0 we need it due to oracle/graal@d2bba8f and graalvm/mx@5eb6d6f 24.1 is still using mx 7.25.5 which doesn't include graalvm/mx@bafad62 so for the time being we don't need the backport (except for consistency). |
@zakkak We should also provide the backport in 24.1. There is a good chance the same will happen there. Lets fix it before it's an issue. The backport is low-risk enough. |
|
Done in #439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #435
(cherry picked from commit 48c154e)