Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 4-digit mx versions #436

Merged

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Jul 17, 2024

The assumption that mx versions follow the MAJOR.MINOR.PATCH versioning
seems to not always hold. E.g. the following releases include an
additional 4th number:

  • 5.275.7.1
  • 6.9.1.1
  • 7.4.1.1

Resolves graalvm/mandrel#771 (comment)

It will need to be backported at least to 24.0

The assumption that mx versions follow the MAJOR.MINOR.PATCH versioning
seems to not always hold. E.g. the following releases include an
additional 4th number:

* 5.275.7.1
* 6.9.1.1
* 7.4.1.1
@zakkak zakkak requested a review from jerboaa July 17, 2024 09:17
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 17, 2024
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zakkak
Copy link
Collaborator Author

zakkak commented Jul 17, 2024

I bumped the JDK version to 24 in CI pipelines as it was trying to build graal/master with JDK 23.

Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good.

@zakkak zakkak merged commit d6ed12e into graalvm:master Jul 17, 2024
6 checks passed
@zakkak zakkak deleted the 2024-07-17-support-non-semantic-mx-versioning branch July 17, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants