-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8327381: Refactor type-improving transformations in BoolNode::Ideal t…
…o BoolNode::Value Reviewed-by: chagedorn, thartmann, jkarthikeyan, epeter
- Loading branch information
Showing
4 changed files
with
169 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
135 changes: 135 additions & 0 deletions
135
test/hotspot/jtreg/compiler/c2/gvn/TestBoolNodeGVN.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
/* | ||
* Copyright (c) 2024 Red Hat and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
package compiler.c2.gvn; | ||
|
||
import compiler.lib.ir_framework.*; | ||
|
||
import java.util.Random; | ||
|
||
/** | ||
* @test | ||
* @bug 8327381 | ||
* @summary Refactor boolean node tautology transformations | ||
* @library /test/lib / | ||
* @run driver compiler.c2.gvn.TestBoolNodeGVN | ||
*/ | ||
public class TestBoolNodeGVN { | ||
public static void main(String[] args) { | ||
TestFramework.run(); | ||
testCorrectness(); | ||
} | ||
|
||
/** | ||
* Test changing ((x & m) u<= m) or ((m & x) u<= m) to always true, same with ((x & m) u< m+1) and ((m & x) u< m+1) | ||
* The test is only applicable to x64, aarch64 and riscv64 for having <code>Integer.compareUnsigned</code> | ||
* intrinsified. | ||
*/ | ||
@Test | ||
@Arguments(values = {Argument.DEFAULT, Argument.DEFAULT}) | ||
@IR(failOn = IRNode.CMP_U, | ||
phase = CompilePhase.AFTER_PARSING, | ||
applyIfPlatformOr = {"x64", "true", "aarch64", "true", "riscv64", "true"}) | ||
public static boolean testShouldReplaceCpmUCase1(int x, int m) { | ||
return !(Integer.compareUnsigned((x & m), m) > 0); // assert in inversions to generates the pattern looking for | ||
} | ||
@Test | ||
@Arguments(values = {Argument.DEFAULT, Argument.DEFAULT}) | ||
@IR(failOn = IRNode.CMP_U, | ||
phase = CompilePhase.AFTER_PARSING, | ||
applyIfPlatformOr = {"x64", "true", "aarch64", "true", "riscv64", "true"}) | ||
public static boolean testShouldReplaceCpmUCase2(int x, int m) { | ||
return !(Integer.compareUnsigned((m & x), m) > 0); | ||
} | ||
|
||
@Test | ||
@Arguments(values = {Argument.DEFAULT, Argument.DEFAULT}) | ||
@IR(failOn = IRNode.CMP_U, | ||
phase = CompilePhase.AFTER_PARSING, | ||
applyIfPlatformOr = {"x64", "true", "aarch64", "true", "riscv64", "true"}) | ||
public static boolean testShouldReplaceCpmUCase3(int x, int m) { | ||
return Integer.compareUnsigned((x & m), m + 1) < 0; | ||
} | ||
|
||
@Test | ||
@Arguments(values = {Argument.DEFAULT, Argument.DEFAULT}) | ||
@IR(failOn = IRNode.CMP_U, | ||
phase = CompilePhase.AFTER_PARSING, | ||
applyIfPlatformOr = {"x64", "true", "aarch64", "true", "riscv64", "true"}) | ||
public static boolean testShouldReplaceCpmUCase4(int x, int m) { | ||
return Integer.compareUnsigned((m & x), m + 1) < 0; | ||
} | ||
|
||
@Test | ||
@Arguments(values = {Argument.DEFAULT, Argument.DEFAULT}) | ||
@IR(counts = {IRNode.CMP_U, "1"}, | ||
phase = CompilePhase.AFTER_PARSING, | ||
applyIfPlatformOr = {"x64", "true", "aarch64", "true", "riscv64", "true"}) | ||
public static boolean testShouldHaveCpmUCase1(int x, int m) { | ||
return !(Integer.compareUnsigned((x & m), m - 1) > 0); | ||
} | ||
|
||
@Test | ||
@Arguments(values = {Argument.DEFAULT, Argument.DEFAULT}) | ||
@IR(counts = {IRNode.CMP_U, "1"}, | ||
phase = CompilePhase.AFTER_PARSING, | ||
applyIfPlatformOr = {"x64", "true", "aarch64", "true", "riscv64", "true"}) | ||
public static boolean testShouldHaveCpmUCase2(int x, int m) { | ||
return !(Integer.compareUnsigned((m & x), m - 1) > 0); | ||
} | ||
|
||
@Test | ||
@Arguments(values = {Argument.DEFAULT, Argument.DEFAULT}) | ||
@IR(counts = {IRNode.CMP_U, "1"}, | ||
phase = CompilePhase.AFTER_PARSING, | ||
applyIfPlatformOr = {"x64", "true", "aarch64", "true", "riscv64", "true"}) | ||
public static boolean testShouldHaveCpmUCase3(int x, int m) { | ||
return Integer.compareUnsigned((x & m), m + 2) < 0; | ||
} | ||
|
||
@Test | ||
@Arguments(values = {Argument.DEFAULT, Argument.DEFAULT}) | ||
@IR(counts = {IRNode.CMP_U, "1"}, | ||
phase = CompilePhase.AFTER_PARSING, | ||
applyIfPlatformOr = {"x64", "true", "aarch64", "true", "riscv64", "true"}) | ||
public static boolean testShouldHaveCpmUCase4(int x, int m) { | ||
return Integer.compareUnsigned((m & x), m + 2) < 0; | ||
} | ||
|
||
private static void testCorrectness() { | ||
int[] values = { | ||
0, 1, 5, 8, 16, 42, 100, new Random().nextInt(0, Integer.MAX_VALUE), Integer.MAX_VALUE | ||
}; | ||
|
||
for (int x : values) { | ||
for (int m : values) { | ||
if (!testShouldReplaceCpmUCase1(x, m) | | ||
!testShouldReplaceCpmUCase2(x, m) | | ||
!testShouldReplaceCpmUCase3(x, m) | | ||
!testShouldReplaceCpmUCase4(x, m)) { | ||
throw new RuntimeException("Bad result for x = " + x + " and m = " + m + ", expected always true"); | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters