[Backport] Delete native methods from java.lang.Thread #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Karm
changed the title
zakkak
approved these changes
Dec 19, 2024
....core/src/com/oracle/svm/core/methodhandles/Target_java_lang_invoke_MethodHandleNatives.java
Outdated
Show resolved
Hide resolved
jerboaa
reviewed
Dec 19, 2024
|
@Karm Please change the title of the PR to something clearer. Without looking up the commit id somewhere else it doesn't say what it's doing. I suggest this commit message (first line as PR title): Thanks! |
It is in no way related as far as my study of the original commit goes. The commit involves like 4 unrelated topics and cleanups. The issue we witnessed was solely about people trying to use reflection to construct a virtual thread when a runtime offering that was detected. I will remove all other unrelated parts then... |
'getStackTrace0' is only used in asyncGetStackTrace() which is deleted as well. Thread.getStackTrace() is replaced by PlatformThreads.getStackTrace(). So it's not reachable. 'getNextThreadIdOffset()' is only used in ThreadIdentifiers private class which is substituted in JDKs better than JDK 19 (which includes 21). So won't be reachable either. Fixes: graalvm#28 This is a partial backport of: "Introudce a mode to unconditionally include classes" oracle/graal@369f0ff8 to address oracle/graal#9672 Only take the java.lang.Thread native method deletions as that's sufficient to fix the issue reported in graalvm#28.
Karm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'getStackTrace0' is only used in asyncGetStackTrace() which is deleted as well.
Thread.getStackTrace() is replaced by PlatformThreads.getStackTrace(). So it's not
reachable.
'getNextThreadIdOffset()' is only used in ThreadIdentifiers private class which is
substituted in JDKs better than JDK 19 (which includes 21). So won't be reachable either.
Fixes: #28
This is a partial backport of:
"Introudce a mode to unconditionally include classes" oracle/graal@369f0ff8
to address oracle/graal#9672
Only take the java.lang.Thread native method deletions as that's sufficient to fix
the issue reported in #28.