Small fixes

src/commands/Fishy/Collection.ts

@@ -41,8 +41,9 @@ export class Collection extends FishyChildCommand<typeof args> {
         .filter((f) => f && f.hidden) as Fishy[]),
     ];
 
-    const embed = this.minimalEmbed()
-    .setTitle(`${perspective.upper.possessive} fishy collection`);
+    const embed = this.minimalEmbed().setTitle(
+      `${perspective.upper.possessive} fishy collection`
+    );
 
     const scrollingEmbed = new ScrollingListView(this.ctx, embed, {
       items: fishyDisplayList,

src/commands/Lastfm/NowPlaying/Config/Set.ts

@@ -79,8 +79,14 @@ export class Set extends NowPlayingConfigChildCommand<typeof args> {
       }
     }
 
+    const successMessage = presetConfig
+      ? `${Emoji.checkmark} Using preset ${code(newConfig[0])}:`
+      : filtered.length
+      ? `${Emoji.checkmark} Successfully set your config as:`
+      : "";
+
     const filteredDisplay = filtered.length
-      ? `${Emoji.checkmark} Successfully set your config as:\n\`\`\`diff
+      ? `\`\`\`diff
 ${filtered.map((f) => `+ ${f}`).join("\n")}\`\`\``
       : "";
     const filteredOutDisplay = filteredOut.length
@@ -90,11 +96,7 @@ ${filteredOut.map((f) => `- ${f}`).join("\n")}\`\`\``
 
     const embed = this.minimalEmbed()
       .setDescription(
-        `${
-          presetConfig
-            ? `${Emoji.checkmark} Using preset ${code(newConfig[0])}`
-            : ""
-        }
+        `${successMessage}
         ${filteredDisplay}
         ${filteredOutDisplay}`.trim()
       )

src/errors/errors.ts

@@ -175,9 +175,7 @@ export class CrownBannedError extends ClientError {
   name = "CrownBannedError";
 
   constructor() {
-    super(
-      "you have been banned from the crowns game. If you think this is an error please speak to a staff member."
-    );
+    super("you have been banned from the crowns game.");
   }
 }
 

src/lib/paginators/PaginatedScrobbleCache.ts

@@ -9,7 +9,7 @@ import { LilacLibraryService } from "../../services/lilac/LilacLibraryService";
 import { GowonContext } from "../context/Context";
 import { displayNumberedList } from "../ui/displays";
 import { EmbedView } from "../ui/views/EmbedView";
-import { ScrollinViewOptions, ScrollingView } from "../ui/views/ScrollingView";
+import { ScrollingView, ScrollingViewOptions } from "../ui/views/ScrollingView";
 import { PaginatedCache } from "./PaginatedCache";
 
 export class PaginatedLilacScrobbleCache extends PaginatedCache<LilacScrobble> {
@@ -47,7 +47,7 @@ export class PaginatedLilacScrobbleCache extends PaginatedCache<LilacScrobble> {
     embed: EmbedView,
     firstPage: LilacScrobblesPage,
     generateTableRow: (scrobble: LilacScrobble) => string,
-    overrides: Partial<ScrollinViewOptions> = {}
+    overrides: Partial<ScrollingViewOptions> = {}
   ): Promise<ScrollingView> {
     const scrollingEmbed = new ScrollingView(this.ctx, embed, {
       initialItems: this.generateTable(

src/lib/ui/fishy.ts

@@ -1,9 +1,8 @@
 import { bold } from "../../helpers/discord";
 import { Fishy } from "../../services/fishy/Fishy";
-import { fishyList } from "../../services/fishy/fishyList";
+import { findFishy, fishyList } from "../../services/fishy/fishyList";
 import { FishyRarityData } from "../../services/fishy/rarity";
 import { Emoji } from "../emoji/Emoji";
-import { displayNumber } from "./displays";
 
 export function displayRarity(
   rarity: FishyRarityData,
@@ -35,6 +34,12 @@ export function displayFishyLevelUp(level: number): string {
 
 export function displayFishyCollectionProgress(collection: string[]) {
   const noHidden = fishyList.filter((f) => !f.hidden);
+  const hiddenCount = collection.filter(
+    (f) => findFishy({ byID: f })?.hidden
+  ).length;
+  const nonHiddenCount = collection.length - hiddenCount;
 
-  return `${displayNumber(collection.length)} of ${noHidden.length}`;
+  return `${nonHiddenCount}${hiddenCount ? `+${hiddenCount}` : ""} of ${
+    noHidden.length
+  }`;
 }

src/lib/ui/views/ScrollingListView.ts

@@ -2,8 +2,8 @@ import { EmbedFieldData } from "discord.js";
 import { GowonContext } from "../../context/Context";
 import { EmbedView } from "./EmbedView";
 import {
-  ScrollinViewOptions,
   ScrollingView,
+  ScrollingViewOptions,
   isEmbedFields,
 } from "./ScrollingView";
 
@@ -18,7 +18,7 @@ export interface ScrollingListViewOptions<T> {
     pageInfo: { page: number; offset: number }
   ) => string;
 
-  overrides?: Partial<ScrollinViewOptions>;
+  overrides?: Partial<ScrollingViewOptions>;
 }
 
 export class ScrollingListView<T> extends ScrollingView {

src/lib/ui/views/ScrollingView.ts

@@ -12,7 +12,7 @@ import { displayNumber } from "../displays";
 import { EmbedView } from "./EmbedView";
 import { View } from "./View";
 
-export interface ScrollinViewOptions {
+export interface ScrollingViewOptions {
   initialItems: string | EmbedFieldData[];
   totalPages: number;
   totalItems: number;
@@ -40,7 +40,7 @@ export function isEmbedFields(
 export class ScrollingView extends View {
   private currentPage = 1;
   private currentItems: string | EmbedFieldData[];
-  private options: ScrollinViewOptions;
+  private options: ScrollingViewOptions;
   private onPageChangeCallback: OnPageChangeCallback = () => "";
 
   private readonly leftArrow = EmojiRaw.arrowLeft;
@@ -51,7 +51,7 @@ export class ScrollingView extends View {
   constructor(
     private ctx: GowonContext,
     private embed: EmbedView,
-    options: Partial<ScrollinViewOptions>
+    options: Partial<ScrollingViewOptions>
   ) {
     super();