-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Modernize the application & Performance tweaks #135
base: master
Are you sure you want to change the base?
Conversation
… react-router-redux to connected-react-router, use PureComponents/memo
I have the same feeling and looking forward to this PR. |
Any updates? |
@klamping I was able to reproduce the issue, it should be fixed now. |
Is anyone maintaining this app anymore? I would be happy to maintain it myself |
@khaledosman One small thing I found, currentUser.image is broken if you define no image, isn't there a way already coded on the API to recover the profile.image smiley face and use it instead of displaying the alt message ? |
@helderscrolls Thanks, I'm not sure where that broke as I didn't change any API related logic, I'll look into it later when I have the time. |
@khaledosman I think it’s a issue that comes from the original Build, the only way I’ve found so far is to hard code the URL on the front-end, on the Header and the Comment preview that way even if currentUser.image is undefined it displays the smiley face |
Help to recreate the store inside the tests.
Add custom render function, wrap the providers.
Move all authentication state to it. BREAKING CHANGE removed loginPageUnloaded and registerPageUnloaded
Unit test the reducer and selectors
Both Login and Register share almost all the UI, so, to reduce duplicate code. BREAKING CHANGE: remove Login and Register components and use only one screen
Now these features are under auth slice. BREAKING CHANGE: remove settingsPageUnloaded
Move to `auth` folder.
Add a slice to manage the comments.
…rade react-router v6
Upgrade codebase
Fix redirect handling on failed login
The repo seems to be a bit out of date and isn't using best practices when it comes to performance for React applications, so this article might be unrealistic for 2019 https://medium.com/free-code-camp/a-realworld-comparison-of-front-end-frameworks-with-benchmarks-2019-update-4be0d3c78075. This PR aims to change that