-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S24 privacy combined profile #2355
Open
jsenning
wants to merge
62
commits into
develop
Choose a base branch
from
s24-privacy-combined-profile
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-cs/gordon-360-ui into s23-fac-privacy-option-ui-2
…cs/gordon-360-ui into s24-privacy-combined-profile-jrs
…ordon-360-ui into s24-privacy-combined-profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #2031
@ArabellaJi began working on this in 2023 and did most of the heavy lifting. She began with the intention of giving FacStaff a mechanism to optionally display their mobile phone number. This then expanded to provide privacy controls for other items on the FacStaff personal profile. Before she handed it off at the start of the summer, she had also expanded her work so that student data (currently mobile phone and home address) used the same mechanisms.
In the past weeks we have continued this work to more completely integrate the new privacy settings and adjusting profile view models to allow individual profile elements have individual boolean values to indicate the user has requested they be private. Doing this meant that many of the profile fields have changed from strings to objects that contain a string and a privacy flag. For example, in both the UI and API the mobile phone field is now has type
ProfileItem
that is a class with two fieldsvalue
andisPrivate
. The value field is the string representing the phone number, and theisPrivate
field is a boolean that is true if the should be treated as confidential (and shown in red). Of course, data the viewing user is not allowed to see is not sent from the API, so theisPrivate
field being true means that the viewing user is authorized to see the information but the color reminds them that the information is restricted and should be treated as such.This change deprecates the use of the "KeepPrivate" profile field for faculty staff accounts and the "isMobilePhonePrivate" field for student accounts (although one outstanding issue is the need to ensure that student mobile phone privacy settings here are appropriately reflected in the Jenzabar database.)
Some profile information still use other types of privacy controls. One example is Clifton Strengths (although this might be an easy fix). Another is the privacy settings for alumni. We hope that in the near future these can be modified to use the new privacy settings.