Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rec-IM] bracket v2 #2347

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

[Rec-IM] bracket v2 #2347

wants to merge 12 commits into from

Conversation

amos-cha
Copy link
Contributor

@amos-cha amos-cha commented Jul 8, 2024

gordon-cs/gordon-360-api#1057

OLD

image

NEW

image
image
image

New component contains these new features:

  • interactive drag-able SVG
  • time details
  • match details links to the match
  • winners can be traced through the entire bracket
  • responsive hover/coloring
  • team names are links to the team page

TODO

  • gordon colors
  • lightmode

Current Style

image
image

All colors are currently hard coded out of selected colors from theme.ts. However, all attempts at using gordon's colors would result in absolute disaster visual results. Moreover, the package does not allow customization of the connector color despite the docs and examples showing that it "should" be possible. This is a package bug and I looked into how the custom theme is combined with the default theme, but the connector is statically set in a file called /src/settings.ts which prevents customization. This results in further visual issues while trying to have dynamic color switches. Furthermore, the base colors are very aesthetic but they clash far too much with light mode, which is why I made the switchup to using Gordon Blue as the base. An issue will have to be made later on for transitioning the Color theme to something more 'sustainable'. But for now, this is a the fix I have come up with.

EDIT COLORS

image
image

After consultation, we've decided that greys were simply more consistent and minimalist. Gordon Blue color theme is still in the codebase if we every choose to use it, but the greys provide a more elegant transition that matches both themes.

@amos-cha amos-cha added Feature Broken Feature Marks an aspect of the site that is broken. More urgent need for resolution than 'Bug' s24 Summer Practicum 2024 labels Jul 8, 2024
@amos-cha amos-cha self-assigned this Jul 8, 2024
@amos-cha amos-cha marked this pull request as draft July 8, 2024 13:06
@amos-cha amos-cha requested a review from EjPlatzer July 8, 2024 16:19
@amos-cha amos-cha marked this pull request as ready for review July 11, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Broken Feature Marks an aspect of the site that is broken. More urgent need for resolution than 'Bug' Feature s24 Summer Practicum 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant