-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rec-IM] bracket v2 #2347
Open
amos-cha
wants to merge
12
commits into
develop
Choose a base branch
from
s24-recim-bracket-v2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Rec-IM] bracket v2 #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amos-cha
added
Feature
Broken Feature
Marks an aspect of the site that is broken. More urgent need for resolution than 'Bug'
s24
Summer Practicum 2024
labels
Jul 8, 2024
…0-ui into s24-recim-bracket-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Broken Feature
Marks an aspect of the site that is broken. More urgent need for resolution than 'Bug'
Feature
s24
Summer Practicum 2024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gordon-cs/gordon-360-api#1057
OLD
NEW
New component contains these new features:
TODO
Current Style
All colors are currently hard coded out of selected colors from
theme.ts
. However, all attempts at using gordon's colors would result in absolute disaster visual results. Moreover, the package does not allow customization of the connector color despite the docs and examples showing that it "should" be possible. This is a package bug and I looked into how the custom theme is combined with the default theme, but the connector is statically set in a file called/src/settings.ts
which prevents customization. This results in further visual issues while trying to havedynamic
color switches. Furthermore, the base colors are very aesthetic but they clash far too much with light mode, which is why I made the switchup to using Gordon Blue as the base. An issue will have to be made later on for transitioning the Color theme to something more 'sustainable'. But for now, this is a the fix I have come up with.EDIT COLORS
After consultation, we've decided that greys were simply more consistent and minimalist. Gordon Blue color theme is still in the codebase if we every choose to use it, but the greys provide a more elegant transition that matches both themes.