Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add more typing to instantiator #697

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

madig
Copy link
Collaborator

@madig madig commented Sep 21, 2020

Still need to deal with

Lib/fontmake/instantiator.py:468: error: Incompatible types in assignment (expression has type "int", variable has type "Optional[WidthClass]")
Lib/fontmake/instantiator.py:632: error: Returning Any from function declared to return "int"
Lib/fontmake/instantiator.py:638: error: Returning Any from function declared to return "int"

This is coming from ufoLib2 types. Still need to see what I can do about them. Also need to add typing to fontTools's otRound.

Base automatically changed from master to main February 15, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant