Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(owl-bot): OwlBot to report a skip in pull request checks #5643

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix(owl-bot): OwlBot to report a skip in pull request checks #5643

wants to merge 4 commits into from

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Dec 23, 2024

  • fix: OwlBot postprocessor to report a check when skipping a PR
  • test: updated test

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@suztomo
fix: OwlBot postprocessor to report a check when skipping a PR
3d17f4c 
OwlBot postprocessor has stopped running the script since
googleapis#5587.
Many repositories mark the postprocessor check as required.
This change reports the check status as success with a message
that indicates the execution was skipped.
@suztomo
test: updated test
10e197a
@suztomo
Copy link
Member Author

suztomo commented Dec 27, 2024 •
edited
Loading

"packages-owl-bot-test (repo-automation-bots) Failing after 1s — Summary" says:

Your build failed to run: generic::invalid_argument: if 'build.service_account' is specified, the build must either (a) specify 'build.logs_bucket', (b) use the REGIONAL_USER_OWNED_BUCKET build.options.default_logs_bucket_behavior option, or (c) use either CLOUD_LOGGING_ONLY / NONE logging options

trigger

@suztomo
Copy link
Member Author

suztomo commented Dec 27, 2024

All checks have passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bot: owl-bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@suztomo